Skip to content

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Jun 20, 2025

Replaces #128437

We required #128576 to actually generate the 9.1 docs with the correct applies_to tagging.

Important

Notes for reviewer

  • If interested in the details of the metadata, please read up on applies_to.

  • If checking the preview URLs, please note that how the applies_to tagging gets rendered will be updated soon, and this front-end stuff is managed by the docs build. Our job writing docs is to supply the correct versions and lifecycle information in the metadata in the docs source pages.

  • Also, just because something is marked "tech preview in 9.0" (for example) it doesn't necessarily mean it wasn't tech preview in previous 8.x versions. It's just that these docs on main are the 9.0+ docs and they don't talk about 8.x or below in the applies_to metadata.

  • I'll open a manual "backport" equivalent to reflect the GA release on 8.x in a follow-up PR

cc @alex-spies this will be the official GAing PR

@leemthompo leemthompo requested a review from nik9000 June 20, 2025 17:50
@leemthompo leemthompo self-assigned this Jun 20, 2025
@leemthompo leemthompo added >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Jun 20, 2025
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jun 20, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

github-actions bot commented Jun 23, 2025

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

- **rendered docs (md):**
  - kql: removed serverless preview, added ga 9.1.0
  - match: removed serverless preview, added ga 9.1.0
  - match_phrase: changed from preview 9.1.0 to unavailable 9.0 + ga 9.1.0
  - qstr: removed serverless preview, added ga 9.1.0
  - search functions list: removed bullet point before term function

- **docs generation code (java):**
  - match_phrase: updated function info annotations to unavailable 9.0 + ga 9.1.0
  - query_string: uncommented ga 9.1.0 annotation
@leemthompo leemthompo removed auto-backport Automatically create backport pull requests when merged v8.19.0 labels Jun 23, 2025
@leemthompo leemthompo changed the title [DOCS][ESQL] Flip preview booleans, to GA search functions [DOCS][ESQL] GA search functions for 9.1 Jun 23, 2025
@leemthompo leemthompo requested a review from kderusso June 23, 2025 19:03
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@leemthompo leemthompo enabled auto-merge (squash) June 23, 2025 19:28
@leemthompo leemthompo merged commit 8c06acc into elastic:main Jun 23, 2025
32 checks passed
@leemthompo leemthompo deleted the leemthompo/flip-fts-esql-ga-9.1 branch June 24, 2025 06:24
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Jun 24, 2025
- removed `preview = true` from java function annotations for full-text search functions
- generated updates to asciidoc and kibana docs
- 8.x equivalent of elastic#129786
@leemthompo
Copy link
Contributor Author

8.19 "backport": #129897

leemthompo added a commit that referenced this pull request Jun 24, 2025
Promote ESQL search functions to GA in the docs

- removed `preview = true` from java function annotations for full-text search functions
- generated updates to asciidoc and kibana docs
- 8.x equivalent of #129786
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 25, 2025
* [DOCS][ESQL] Flip preview booleans, to GA search functions

* render docs, tweak some applies_to metadata in docs gen code

- **rendered docs (md):**
  - kql: removed serverless preview, added ga 9.1.0
  - match: removed serverless preview, added ga 9.1.0
  - match_phrase: changed from preview 9.1.0 to unavailable 9.0 + ga 9.1.0
  - qstr: removed serverless preview, added ga 9.1.0
  - search functions list: removed bullet point before term function

- **docs generation code (java):**
  - match_phrase: updated function info annotations to unavailable 9.0 + ga 9.1.0
  - query_string: uncommented ga 9.1.0 annotation
```{applies_to}
stack: preview 9.1.0
serverless: preview
stack: unavailable 9.0, ga 9.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leemthompo I don't think we want to add an explicit unavailable lifecycle state for states before a feature was available

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shainaraskas New and interesting cans of worms everywhere! I understand, it's just a bit of an outlier that MATCH_PHRASE burst straight onto the scene in GA in 9.1.0 and so feels useful to know that it wasn't available in 9.0 like the other search functions. But maybe I was trying to wring more expressivity out of these lifecycles than they contain?

I'll rip it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes Team:Docs Meta label for docs team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants